Skip to content

fix: connection interface end names dropped on textual SysML export#2275

Open
mvanhorn wants to merge 1 commit into
eclipse-syson:mainfrom
mvanhorn:fix/2264-2026-06-12-1531-fix-connection-empty-ends-text-export
Open

fix: connection interface end names dropped on textual SysML export#2275
mvanhorn wants to merge 1 commit into
eclipse-syson:mainfrom
mvanhorn:fix/2264-2026-06-12-1531-fix-connection-empty-ends-text-export

Conversation

@mvanhorn

@mvanhorn mvanhorn commented Jun 12, 2026 •
edited by AxelRICHARD
Loading

Copy link
Copy Markdown

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Interface-type connections now serialize their two ends when exporting to textual SysML, producing connection interface1 connect heater.socket to outlet; instead of connection interface1 connect to ;. #2264 (@AxelRICHARD acknowledged) reported that the textual export drops the end references for interface connections while Flow connections were unaffected, which pointed at a divergent branch in the connection-end serialization path. In SysMLElementSerializer, the interface-connection case did not emit the qualified end names the way the working flow branch does, so the connect <end1> to <end2> form came out empty; the fix resolves and emits each end's qualified feature name on that path. A serializer test covers an interface connection between two ports and asserts the exported text carries both qualified end names, with the existing flow-connection serialization unchanged.

Fixes #2264

ECA: this contribution requires an Eclipse Contributor Agreement sign-off, which the eca bot will verify against the commit author.

Auto review

  • Have you reviewed this PR?

Project management

  • Has the pull request been added to the relevant milestone? (maintainer-side)
  • Have the priority: and pr: labels been added? (maintainer-side)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues?
  • Have the relevant issues been added to the same project milestone? (maintainer-side)

Changelog and release notes

  • Has the CHANGELOG.adoc been updated? (defer to maintainer for the target release file)
  • Have the relevant API breaks been described? (none in this change)
  • Are the new / upgraded dependencies mentioned? (none)
  • In case of a change with a visual impact, are there screenshots? (no visual impact)
  • In case of a key change, has it been added to Key highlights? (not a key change)

Documentation

  • Have you included a documentation update? (no manual update needed; serializer bugfix)

Tests

  • Is the code properly tested?

@mvanhorn mvanhorn mentioned this pull request Jun 12, 2026
Open
@AxelRICHARD AxelRICHARD added this to the 2026.7.0 milestone Jun 12, 2026
@AxelRICHARD

AxelRICHARD commented Jun 12, 2026

Copy link
Copy Markdown
Member

Hello,

Thank you for providing this PR. Could you please add an entry to the CHANGELOG as required by the PR template?
Could you also signed the Eclipse Contributor Agreement (ECA) https://www.eclipse.org/legal/eca/ please ? I won't be able to merge the PR if you don't sign it.

Thank you again,

Regards,

@AxelRICHARD

AxelRICHARD commented Jun 12, 2026

Copy link
Copy Markdown
Member

You also need to follow this rule https://doc.mbse-syson.org/syson/v2026.5.0/developer-guide/index.html#_contribute_a_change_in_the_codebase about the commit message.

Thank you

@AxelRICHARD

AxelRICHARD commented Jun 25, 2026

Copy link
Copy Markdown
Member

Hello @mvanhorn, do you plan to take into account my remarks and fix the PR?

@AxelRICHARD

AxelRICHARD commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Hello @mvanhorn, if you do not plan to fix this PR, do you allow me to push my own PR based on your work?
Thank you for your answer.
Regards,

This was referenced Jun 29, 2026
Open
Open
@mvanhorn mvanhorn force-pushed the fix/2264-2026-06-12-1531-fix-connection-empty-ends-text-export branch from c4f1dcc to 13d9219 Compare July 4, 2026 00:36
@mvanhorn

mvanhorn commented Jul 4, 2026

Copy link
Copy Markdown
Author

Apologies for the slow reply, and yes - I intend to finish this PR. Both remarks are addressed in 13d9219: added the #2264 entry to the CHANGELOG Bug fixes section, and reworded the commit to the [2264] convention from the developer guide. The ECA signature is in progress on my side - I'll confirm here once it's done. Thanks for your patience.

@mvanhorn mvanhorn force-pushed the fix/2264-2026-06-12-1531-fix-connection-empty-ends-text-export branch from 13d9219 to 5590e12 Compare July 4, 2026 05:04
@mvanhorn
[2264] Fix connection interface end names dropped on textual SysML ex…
7540678 
…port

Bug: eclipse-syson#2264

Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
@mvanhorn mvanhorn force-pushed the fix/2264-2026-06-12-1531-fix-connection-empty-ends-text-export branch from 5590e12 to 7540678 Compare July 4, 2026 05:07
@mvanhorn

mvanhorn commented Jul 4, 2026

Copy link
Copy Markdown
Author

ECA is signed and the eclipsefdn/eca check is now green (I re-authored the commit with my registered Eclipse account email). That should be everything from your list: CHANGELOG entry, commit message convention, and the ECA. Ready for review whenever you are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: to review later priority: low

Projects

None yet

Milestone

2026.7.0

Development

Successfully merging this pull request may close these issues.

Creating a new interface type connection in the diagram editor causes an empty entry to appear [v2026.5.0]

2 participants

@mvanhorn @AxelRICHARD